fix(env): one login-shell-derived PATH for every spawned tool (T-439)

Desktop/dock-launched clide inherits a sparse PATH (no ~/.local/bin, brew,
nvm, …), so pql/git/claude and PTY tools went missing. T-347 fixed only the
toolchain/pql path on Linux; env.dart's expander was still macOS-only and
claude/PTY/git used the raw PATH — the breakage recurred per spawn site
because there were three divergent expanders.

Consolidate into one resolver (lib/src/env/shell_env.dart):
- primeLoginShellPath(): probe the user's real login shell once at startup
  (`$SHELL -l -c`, sentinel-framed, bounded timeout, graceful fallback to the
  process PATH). Captures the user's actual PATH, not a hardcoded guess.
- expandToolPath(): the canonical merge (moved from toolchain_paths, which
  re-exports it for its tests) — unions the well-known user/local bin dirs.
- resolvedToolPath(): currentSearchPath() + expandToolPath, the single call
  every spawn site uses.

Routed through it: PTY children (registry.dart now overrides PATH), git
(env.dart → operations.dart), the toolchain probe (toolchain_paths), and
hosted claude (agent_bootstrap). Primed in main.dart's !kIsWeb boot. Deleted
the macOS-only env.dart copy and the cli_install copy.

Tests: new shell_env_test (probe + every fallback + merge); env_test and
cli_install_test updated to the consolidated surface. analyze clean, web wasm
build still green, make test green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-15 17:46:11 +02:00
co-authored by Claude Opus 4.8
parent ca08c2a17d
commit 03d053274e
13 changed files with 269 additions and 87 deletions
+7 -22
View File
@@ -8,29 +8,14 @@
/// the renderer can do true colour.
library;
import 'dart:io';
import 'package:clide/src/env/shell_env.dart' show resolvedToolPath;
/// On macOS, GUI apps inherit a minimal PATH that omits Homebrew,
/// ~/.local/bin, and similar directories. This getter returns the
/// platform PATH with those well-known directories merged in.
/// On Linux/Windows it returns the PATH unchanged.
String get expandedPath {
_cachedPath ??= _buildExpandedPath();
return _cachedPath!;
}
String? _cachedPath;
String _buildExpandedPath() {
final base = Platform.environment['PATH'] ?? '';
if (!Platform.isMacOS) return base;
final home = Platform.environment['HOME'] ?? '';
final extras = <String>[if (home.isNotEmpty) '$home/.local/bin', '/opt/homebrew/bin', '/opt/homebrew/sbin', '/usr/local/bin'];
final existing = base.split(':').toSet();
final missing = extras.where((p) => !existing.contains(p));
if (missing.isEmpty) return base;
return [...missing, ...existing].join(':');
}
/// The full tool search PATH for PTY children and PATH-resolved subprocess
/// lookup — delegates to the shared resolver ([resolvedToolPath], T-439) so
/// every spawn site agrees: the login-shell PATH (probed once at startup)
/// unioned with the well-known user/local bin dirs. Previously this was a
/// macOS-only merge, so a Linux desktop launch left tools unresolvable.
String get expandedPath => resolvedToolPath();
/// Base env clide builds for every PTY child. Callers merge with the
/// user's environment — a child that needs user env like `HOME` /